mirror of
https://github.com/casjaysdevdocker/xfce4
synced 2026-08-03 03:52:02 -04:00
jason
5ed417d6e5
xfce4 / release-xfce4 (push) Failing after 1m21s
- rootfs/usr/local/bin/entrypoint.sh:
1. The "start all services" gate
(`if [ "$START_SERVICES" = "yes" ] || [ -z "$1" ]`) always evaluated
true on a first-run container regardless of $1, because
START_SERVICES is force-set to "yes" whenever no PID file exists yet.
Any command passed to `docker run` — `exec ...`, `sh -c ...`,
`shell`, or an arbitrary program — was swallowed into the
service-start+monitor branch before reaching the `case "$1"`
statement that already handles those subcommands, hanging the
container as a daemon instead of running the given command. Changed
the condition to `if [ -z "$1" ]` so the daemon branch only fires
when no command was given at all.
2. The `*/bin/sh | */bin/bash | bash | sh | shell)` case branch
unconditionally shifted $1 before `__exec_command "$@"` (a bare
`exec "$@"`). For `docker run image sh -c 'cmd'` this turned the
exec into `exec -c cmd` (command not found, exit 127) instead of
`exec sh -c 'cmd'`. Split the branch: real interpreter names
(*/bin/sh, */bin/bash, bash, sh) now pass through unshifted; the
"shell" keyword (not a real interpreter) gets its own branch that
shifts and prepends "sh" to any remaining args, or falls back to a
bare `__exec_command` (exec bash -l) when none remain.
Verified `bash -n` passes. Found and fixed upstream in
dockersrc/go, confirmed identical in this repo's generated
entrypoint.sh, and mechanically applied here with the same patch.
👋 Welcome to xfce4 🚀
xfce4 README
Install my system scripts
sudo bash -c "$(curl -q -LSsf "https://github.com/systemmgr/installer/raw/main/install.sh")"
sudo systemmgr --config && sudo systemmgr install scripts
Automatic install/update
dockermgr update xfce4
Install and run container
dockerHome="/srv/$USER/docker/casjaysdevdocker/xfce4/xfce4/latest/rootfs"
mkdir -p "/srv/$USER/docker/xfce4/rootfs"
git clone "https://github.com/dockermgr/xfce4" "$HOME/.local/share/CasjaysDev/dockermgr/xfce4"
cp -Rfva "$HOME/.local/share/CasjaysDev/dockermgr/xfce4/rootfs/." "$dockerHome/"
docker run -d \
--restart always \
--privileged \
--name casjaysdevdocker-xfce4-latest \
--hostname xfce4 \
-e TZ=${TIMEZONE:-America/New_York} \
-v "$dockerHome/data:/data:z" \
-v "$dockerHome/config:/config:z" \
-p 80:80 \
casjaysdevdocker/xfce4:latest
via docker-compose
version: "2"
services:
ProjectName:
image: casjaysdevdocker/xfce4
container_name: casjaysdevdocker-xfce4
environment:
- TZ=America/New_York
- HOSTNAME=xfce4
volumes:
- "/srv/$USER/docker/casjaysdevdocker/xfce4/xfce4/latest/rootfs/data:/data:z"
- "/srv/$USER/docker/casjaysdevdocker/xfce4/xfce4/latest/rootfs/config:/config:z"
ports:
- 80:80
restart: always
Get source files
dockermgr download src casjaysdevdocker/xfce4
OR
git clone "https://github.com/casjaysdevdocker/xfce4" "$HOME/Projects/github/casjaysdevdocker/xfce4"
Build container
cd "$HOME/Projects/github/casjaysdevdocker/xfce4"
buildx