mirror of
https://github.com/casjaysdevdocker/opengist
synced 2026-08-14 14:01:17 -04:00
jason
d069ff42fe
Found while regenerating .env.scripts in Step 1: gen-dockerfile --update left the Dockerfile with zero diff, but it still carries three labels AI.md's OCI label standard explicitly says must not exist. Not fixed here to keep this pass scoped to the template-update runbook and the build/test verification the user asked for; logging so it isn't lost. - TODO.AI.md: add a new item for org.opencontainers.image.base.name, org.opencontainers.image.schema-version, and the duplicate/wrong-value org.opencontainers.image.authors label in Dockerfile
33 lines
2.0 KiB
Markdown
33 lines
2.0 KiB
Markdown
# TODO.AI.md
|
|
|
|
Pre-existing script-lint findings on `rootfs/usr/local/etc/docker/functions/entrypoint.sh`,
|
|
found while fixing the container restart-loop bug. Not caused by that fix; deferred here
|
|
since they are unrelated cleanup, not a functional regression. This file is fully regenerated
|
|
from the shared upstream template (`casjay-dotfiles/scripts`) on every template-update run, so
|
|
these findings must be fixed upstream in the template, not patched locally in this repo — a
|
|
local patch would be silently overwritten by the next `AI.md` runbook run.
|
|
|
|
Read: AI.md (Docker Template Update Runbook), Step 3/5
|
|
|
|
- [ ] `grep` calls missing `--` before the pattern (lines 80, 92, 105, 111, 139, 140, 141, 166,
|
|
167, 169, 178, 229, 388, 693, 749, 759, 790, 792, 803, 820, 863, 909, 920, 944) — add `--`
|
|
per `~/.claude/memory/tool_conventions.md`
|
|
- [ ] `__fix_permissions()` (line 744): `change_user`/`change_group` assigned without `local`
|
|
- [ ] `__initialize_db_users()` (lines 1380-1385): `db_normal_user`, `db_normal_pass`,
|
|
`db_admin_user`, `db_admin_pass` assigned without `local`
|
|
- [ ] `__initialize_custom_bin_dir()` (line 1428): `create_bin_name` assigned without `local`
|
|
- [ ] No `VERSION=` assignment in body to match the `##@Version` header (functions library —
|
|
confirm whether versioning is required for this file type before adding)
|
|
|
|
## [ ] Remove forbidden OCI labels from Dockerfile
|
|
Read: AI.md § OCI label standard (lines 55-85)
|
|
|
|
Found during the build/test pass — `gen-dockerfile --update` left the Dockerfile untouched
|
|
(zero diff), but it still carries labels AI.md explicitly says must not exist:
|
|
- [ ] `LABEL org.opencontainers.image.base.name="${IMAGE_NAME}"` — belongs on the base image,
|
|
not the app image; remove
|
|
- [ ] `LABEL org.opencontainers.image.schema-version="${BUILD_VERSION}"` — non-spec, redundant
|
|
with `version`; remove
|
|
- [ ] `LABEL org.opencontainers.image.authors="${LICENSE}"` — duplicate `authors` label with
|
|
the wrong value (a license string, not an author); remove or fix
|