mirror of
https://github.com/casjaysdevdocker/gitea
synced 2026-08-14 14:01:17 -04:00
Brought the Dockerfile's LABEL block back in line with AI.md's OCI
label standard (lines 58-87).
- Dockerfile: removed `org.opencontainers.image.base.name` (belongs
on the base image, not the app image) and
`org.opencontainers.image.schema-version` (non-spec, redundant with
`version`); removed the duplicate `authors="${LICENSE}"` line and
the duplicate `source="https://docker.io/..."` line, replacing the
former with the correct `org.opencontainers.image.licenses="${LICENSE}"`
label and keeping a single `source` pointing at the github.com repo
- TODO.AI.md: marked this finding fixed
This commit is contained in:
+4
-7
@@ -201,19 +201,16 @@ WORKDIR /root
|
|||||||
LABEL maintainer="CasjaysDev <docker-admin@casjaysdev.pro>"
|
LABEL maintainer="CasjaysDev <docker-admin@casjaysdev.pro>"
|
||||||
LABEL org.opencontainers.image.vendor="CasjaysDev"
|
LABEL org.opencontainers.image.vendor="CasjaysDev"
|
||||||
LABEL org.opencontainers.image.authors="CasjaysDev"
|
LABEL org.opencontainers.image.authors="CasjaysDev"
|
||||||
LABEL org.opencontainers.image.description="Containerized version of ${IMAGE_NAME}"
|
LABEL org.opencontainers.image.licenses="${LICENSE}"
|
||||||
LABEL org.opencontainers.image.title="${IMAGE_NAME}"
|
LABEL org.opencontainers.image.title="${IMAGE_NAME}"
|
||||||
LABEL org.opencontainers.image.base.name="${IMAGE_NAME}"
|
LABEL org.opencontainers.image.description="Containerized version of ${IMAGE_NAME}"
|
||||||
LABEL org.opencontainers.image.authors="${LICENSE}"
|
|
||||||
LABEL org.opencontainers.image.created="${BUILD_DATE}"
|
LABEL org.opencontainers.image.created="${BUILD_DATE}"
|
||||||
LABEL org.opencontainers.image.version="${BUILD_VERSION}"
|
LABEL org.opencontainers.image.version="${BUILD_VERSION}"
|
||||||
LABEL org.opencontainers.image.schema-version="${BUILD_VERSION}"
|
|
||||||
LABEL org.opencontainers.image.url="https://docker.io/casjaysdevdocker/gitea"
|
|
||||||
LABEL org.opencontainers.image.source="https://docker.io/casjaysdevdocker/gitea"
|
|
||||||
LABEL org.opencontainers.image.vcs-type="Git"
|
|
||||||
LABEL org.opencontainers.image.revision="${GIT_COMMIT}"
|
LABEL org.opencontainers.image.revision="${GIT_COMMIT}"
|
||||||
|
LABEL org.opencontainers.image.url="https://docker.io/casjaysdevdocker/gitea"
|
||||||
LABEL org.opencontainers.image.source="https://github.com/casjaysdevdocker/gitea"
|
LABEL org.opencontainers.image.source="https://github.com/casjaysdevdocker/gitea"
|
||||||
LABEL org.opencontainers.image.documentation="https://github.com/casjaysdevdocker/gitea"
|
LABEL org.opencontainers.image.documentation="https://github.com/casjaysdevdocker/gitea"
|
||||||
|
LABEL org.opencontainers.image.vcs-type="Git"
|
||||||
LABEL com.github.containers.toolbox="false"
|
LABEL com.github.containers.toolbox="false"
|
||||||
|
|
||||||
ENV ENV=~/.bashrc
|
ENV ENV=~/.bashrc
|
||||||
|
|||||||
+9
-1
@@ -70,7 +70,15 @@ Needs syncing back to the upstream template per AI.md's runbook.
|
|||||||
lines (~line 241) in `rootfs/usr/local/bin/entrypoint.sh`. Needs syncing to the upstream
|
lines (~line 241) in `rootfs/usr/local/bin/entrypoint.sh`. Needs syncing to the upstream
|
||||||
template per AI.md's runbook.
|
template per AI.md's runbook.
|
||||||
|
|
||||||
|
## OCI label cleanup done — forbidden labels removed from Dockerfile
|
||||||
|
|
||||||
|
- Removed `org.opencontainers.image.base.name` (belongs on the base image, not the app image) and
|
||||||
|
`org.opencontainers.image.schema-version` (non-spec, redundant with `version`).
|
||||||
|
- Removed the duplicate `org.opencontainers.image.authors="${LICENSE}"` line and duplicate
|
||||||
|
`org.opencontainers.image.source="https://docker.io/..."` line; the license value now correctly
|
||||||
|
populates the (previously missing) `org.opencontainers.image.licenses` label per AI.md's OCI
|
||||||
|
label standard (lines 58-87), and `source` keeps the single github.com URL.
|
||||||
|
|
||||||
## Other observations not yet actioned
|
## Other observations not yet actioned
|
||||||
|
|
||||||
- `.gitea/workflows/docker.yaml` uses the same stale/unpinned action pattern (`@v2`-`@v4`, DockerHub-only, `catthehacker/ubuntu:act-latest`) that was removed from the `opengist` repo's duplicate workflow — no `build.yml` counterpart exists here yet.
|
- `.gitea/workflows/docker.yaml` uses the same stale/unpinned action pattern (`@v2`-`@v4`, DockerHub-only, `catthehacker/ubuntu:act-latest`) that was removed from the `opengist` repo's duplicate workflow — no `build.yml` counterpart exists here yet.
|
||||||
- `Dockerfile` sets forbidden OCI labels (`org.opencontainers.image.base.name`, `.schema-version`, duplicate `authors`) — same issue previously found and fixed in `opengist`.
|
|
||||||
|
|||||||
Reference in New Issue
Block a user