From 534d2802dc706a16dd46821872c123d3d1e1d8e5 Mon Sep 17 00:00:00 2001 From: casjay Date: Wed, 5 Aug 2026 23:23:19 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20Remove=20forbidden=20OCI=20label?= =?UTF-8?q?s=20from=20Dockerfile=20=F0=9F=A7=B9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Brought the Dockerfile's LABEL block back in line with AI.md's OCI label standard (lines 58-87). - Dockerfile: removed `org.opencontainers.image.base.name` (belongs on the base image, not the app image) and `org.opencontainers.image.schema-version` (non-spec, redundant with `version`); removed the duplicate `authors="${LICENSE}"` line and the duplicate `source="https://docker.io/..."` line, replacing the former with the correct `org.opencontainers.image.licenses="${LICENSE}"` label and keeping a single `source` pointing at the github.com repo - TODO.AI.md: marked this finding fixed --- Dockerfile | 11 ++++------- TODO.AI.md | 10 +++++++++- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/Dockerfile b/Dockerfile index cec47b4..8810bbc 100644 --- a/Dockerfile +++ b/Dockerfile @@ -201,19 +201,16 @@ WORKDIR /root LABEL maintainer="CasjaysDev " LABEL org.opencontainers.image.vendor="CasjaysDev" LABEL org.opencontainers.image.authors="CasjaysDev" -LABEL org.opencontainers.image.description="Containerized version of ${IMAGE_NAME}" +LABEL org.opencontainers.image.licenses="${LICENSE}" LABEL org.opencontainers.image.title="${IMAGE_NAME}" -LABEL org.opencontainers.image.base.name="${IMAGE_NAME}" -LABEL org.opencontainers.image.authors="${LICENSE}" +LABEL org.opencontainers.image.description="Containerized version of ${IMAGE_NAME}" LABEL org.opencontainers.image.created="${BUILD_DATE}" LABEL org.opencontainers.image.version="${BUILD_VERSION}" -LABEL org.opencontainers.image.schema-version="${BUILD_VERSION}" -LABEL org.opencontainers.image.url="https://docker.io/casjaysdevdocker/gitea" -LABEL org.opencontainers.image.source="https://docker.io/casjaysdevdocker/gitea" -LABEL org.opencontainers.image.vcs-type="Git" LABEL org.opencontainers.image.revision="${GIT_COMMIT}" +LABEL org.opencontainers.image.url="https://docker.io/casjaysdevdocker/gitea" LABEL org.opencontainers.image.source="https://github.com/casjaysdevdocker/gitea" LABEL org.opencontainers.image.documentation="https://github.com/casjaysdevdocker/gitea" +LABEL org.opencontainers.image.vcs-type="Git" LABEL com.github.containers.toolbox="false" ENV ENV=~/.bashrc diff --git a/TODO.AI.md b/TODO.AI.md index 05da4f9..b47d1af 100644 --- a/TODO.AI.md +++ b/TODO.AI.md @@ -70,7 +70,15 @@ Needs syncing back to the upstream template per AI.md's runbook. lines (~line 241) in `rootfs/usr/local/bin/entrypoint.sh`. Needs syncing to the upstream template per AI.md's runbook. +## OCI label cleanup done — forbidden labels removed from Dockerfile + +- Removed `org.opencontainers.image.base.name` (belongs on the base image, not the app image) and + `org.opencontainers.image.schema-version` (non-spec, redundant with `version`). +- Removed the duplicate `org.opencontainers.image.authors="${LICENSE}"` line and duplicate + `org.opencontainers.image.source="https://docker.io/..."` line; the license value now correctly + populates the (previously missing) `org.opencontainers.image.licenses` label per AI.md's OCI + label standard (lines 58-87), and `source` keeps the single github.com URL. + ## Other observations not yet actioned - `.gitea/workflows/docker.yaml` uses the same stale/unpinned action pattern (`@v2`-`@v4`, DockerHub-only, `catthehacker/ubuntu:act-latest`) that was removed from the `opengist` repo's duplicate workflow — no `build.yml` counterpart exists here yet. -- `Dockerfile` sets forbidden OCI labels (`org.opencontainers.image.base.name`, `.schema-version`, duplicate `authors`) — same issue previously found and fixed in `opengist`.