From 8d8f6f6316ec2e5bfea8cf7bde84e37a6b39dec5 Mon Sep 17 00:00:00 2001 From: casjay Date: Mon, 27 Jul 2026 11:36:47 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Fix=20stale=20compile-stage=20co?= =?UTF-8?q?mments=20in=20Dockerfile=20=F0=9F=93=9D?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Comments still described the old native-cross-compile fallback that was removed when the rust-tools stage switched to cargo binstall --disable-strategies compile (prebuilt-only). - Dockerfile: update rust-tools stage header comment to describe prebuilt-fetch behavior instead of native compilation - Dockerfile: update comment above the rust-tools COPY to say "fetched as prebuilts" instead of "compiled natively" --- Dockerfile | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Dockerfile b/Dockerfile index 15422e6..14d63d3 100644 --- a/Dockerfile +++ b/Dockerfile @@ -31,12 +31,13 @@ ARG BUILD_VERSION="${BUILD_DATE}" FROM tianon/gosu:latest AS gosu -# ─── native cross-compile stage ─────────────────────────────────────────────── +# ─── native prebuilt-fetch stage ────────────────────────────────────────────── # Mirrors the go-tools pattern: runs on the build platform (always native amd64 -# in CI). For arm64 targets the musl cross-toolchain compiles natively instead -# of under QEMU — turning a 15-hour emulated build into a 30-60 minute one. -# cargo binstall --target fetches prebuilt binaries from GitHub releases; -# for tools without prebuilts it falls back to native cross-compilation. +# in CI). Tool binaries are fetched as prebuilts for the target arch — no +# compilation, no QEMU — turning a 15-hour emulated build into minutes. +# cargo binstall --disable-strategies compile fetches prebuilt binaries from +# GitHub releases only; tools without a prebuilt for the target arch are +# skipped rather than compiled from source. FROM --platform=$BUILDPLATFORM rust:alpine AS rust-tools ARG TARGETARCH @@ -283,7 +284,7 @@ RUN echo "Custom Applications"; \ $SHELL_OPTS; \ echo "" -# Target-arch tool binaries compiled natively in the rust-tools stage; +# Target-arch tool binaries fetched as prebuilts in the rust-tools stage; # copied here before 05-custom.sh runs so the symlink loop picks them up COPY --from=rust-tools /rust-tools/bin/ /usr/local/share/cargo/bin/