5 Commits

Include renames

Author	SHA1	Message	Date
jason	fc3e148bb2	🐛 Create /config/env directory before services write into it 🐛 ... App-breaking bug found during full runtime verification of the act_runner cache-server feature: `/config/env` was never explicitly created. It only came into existence as a side effect of `__create_env_file()` copying `/usr/local/etc/docker/env/default.sample` into it — but that sample file does not exist in this image's rootfs, so `__create_env_file()` returns early without creating the directory. `05-dockerd.sh` and `zz-act_runner.sh` then failed writing `/config/env/docker.local.sh` and `/config/env/act_runner.local.sh` directly, logging `No such file or directory` (non-fatal, but a real bug). - rootfs/usr/local/bin/entrypoint.sh: added `mkdir -p "/config/env" 2>/dev/null || true` alongside the other `/config/*` directory creation lines - TODO.AI.md: logged the fix and the upstream-template-sync follow-up Verified: full end-to-end run with `--privileged --cap-add CHOWN --cap-add SYS_TIME --cap-add SYS_ADMIN` (per README) shows no more "No such file or directory" errors, gitea starts on port 80, dockerd starts, act_runner cache server logs "Cache server has been started and is listening on 44015", and both configured runners register successfully ("Runner registered successfully." x2, RUNNERS_START=2). `runners-cache.yaml` is generated with real (non-REPLACE_) cache config values.	2026-08-05 01:52:09 -04:00
jason	6ebe62790a	🐛 Fix __format_variables returning a single space for empty input 🐛 ... App-breaking bug found during full runtime verification of the act_runner cache-server feature: gitea failed to start with `Command error: unknown command: /config/gitea/app.ini` because its `--port` argument was empty. Root cause: `__format_variables()` ran `printf '%s\n' $input | sort -Ru | tr '\n' ' '` unconditionally. When `$input` word-splits to zero words (whitespace-only, e.g. no port env vars set), `printf` with a `%s` format still runs once with a missing arg, emitting a blank line — so the function returned a single space `" "` instead of empty. That made `ENV_PORTS` / `WEB_SERVER_PORTS` resolve to `" "`, which made `SERVICE_PORT` in `08-gitea.sh` become `" "` — non-empty per `[ -n ... ]` but rendering as an empty `--port` value to `gitea web`. - rootfs/usr/local/etc/docker/functions/entrypoint.sh: replaced `[ -z "$input" ] && return 0` with `[[ "$input" =~ [^[:space:]] ]] || return 0` so whitespace-only input is treated as empty before reaching the `printf` pipeline - TODO.AI.md: logged the fix and the upstream-template-sync follow-up Verified: rebuilt the image and confirmed `gitea will be running on port 80` / `gitea web --port 80 ...` in a full container run (previously `--port` with no value).	2026-08-05 01:51:13 -04:00
jason	8990a72bd7	🐛 Fix __random_password SIGPIPE abort under pipefail 🐛 ... App-breaking bug found during full runtime verification of the act_runner cache-server feature: `__random_password()`'s `tr | head -c` pipeline could be killed by SIGPIPE once `head -c` closes its input early, and under `set -eo pipefail` this aborted the whole script. - rootfs/usr/local/etc/docker/functions/entrypoint.sh: wrapped the `tr -dc ... | head -c...` pipeline in `{ ... } || true` so a SIGPIPE from `head` closing early no longer aborts the script - TODO.AI.md: logged the fix and the upstream-template-sync follow-up	2026-08-05 01:50:16 -04:00
jason	97270cfe91	🐛 Fix silent set -e abort on unguarded DEBUGGER echo pattern 🐛 ... App-breaking bug found during full runtime verification of the act_runner cache-server feature: the container died immediately on every startup, printing only the initial banner line, with no error message. Root cause: 26 occurrences of `[ "$DEBUGGER" = "on" ] && echo/printf/ __service_banner "..."` used as a bare (non-if-guarded) statement. Under `set -eo pipefail`, when `$DEBUGGER` is not "on" (the default), the test fails and the statement's exit status is nonzero, aborting the whole script silently. Confirmed via `bash -x` trace pinpointing the exact crash line. - rootfs/usr/local/etc/docker/functions/entrypoint.sh: appended `|| true` to all 26 occurrences of the pattern - TODO.AI.md: logged the fix and the upstream-template-sync follow-up (functions/entrypoint.sh is normally regenerated from casjay-dotfiles, not hand-edited)	2026-08-05 01:49:20 -04:00
jason	6a3a9bde14	🚀 Enable shared act_runner cache-server 🚀 ... Turned on the act_runner Actions cache instead of leaving it disabled. The standalone `cache-server` process was already being launched unconditionally by zz-act_runner.sh but had no `external_secret`, so it was refusing to start (the binary requires a non-empty secret even though its own `cache.enabled` field is unused). Wired a shared, randomly generated secret through the existing REPLACE_* templating pattern so the "gitea" runner, the cache-server, and the extra runner-N daemons spawned by start-runners all share one cache backend. - rootfs/tmp/etc/act_runner/default_config.yaml: cache.enabled: true; added external_server (pointed at the local cache-server) and external_secret placeholders - rootfs/tmp/etc/act_runner/cache_server.yaml: cache.enabled: true; added external_secret placeholder (required for the binary to start) - rootfs/usr/local/etc/docker/init.d/zz-act_runner.sh: added __gen_cache_secret() (mirrors __gen_auth_token's persisted-token pattern, stored at $CONF_DIR/tokens/cache_secret); substitutes REPLACE_RUNNER_CACHE_SECRET into both the runner config and the cache-server config; exports RUNNER_CACHE_HOST/PORT/SECRET for start-runners; bumped version stamp - rootfs/usr/local/bin/start-runners: generates a shared runners-cache.yaml from the exported cache env vars and passes --config to both `act_runner register` and `act_runner daemon` for every runner-N instance, so they use the same external cache server instead of an unshared per-process local cache - TODO.AI.md: logged pre-existing script-lint findings (missing `--` before grep queries throughout zz-act_runner.sh, a UUOC in start-runners, an unpinned/stale docker.yaml CI workflow, and forbidden OCI labels in the Dockerfile) surfaced incidentally by the lint pass for this change but out of scope for it	2026-08-03 11:57:10 -04:00