From ddc318052c0b7ad8ef6c3ff5af3633b3c7238f3f Mon Sep 17 00:00:00 2001 From: casjay Date: Fri, 5 Jun 2026 13:42:50 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Fix=20compose=20example=20to=20f?= =?UTF-8?q?ollow=20conventions=20=F0=9F=93=9D?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add x-logging anchor with json-file driver - Add pull_policy: always - Add logging: *default-logging - Add network block (gitea / external: false) - Switch environment from list to map format - Add CONTAINER_NAME to environment - Use HOSTNAME: ${BASE_HOST_NAME:-...} pattern - Switch volumes from absolute paths to ./volumes relative paths - Bind ports to 172.17.0.1 (not 0.0.0.0) - Add cgroupns_mode: private - Add port comment at top of file - README.md: bring compose example into line with dockerfile_conventions.md README.md --- README.md | 37 ++++++++++++++++++++++++++++--------- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index c66aadd..a943e35 100644 --- a/README.md +++ b/README.md @@ -36,31 +36,50 @@ docker run -d \ ### via docker compose ```yaml +# nginx proxy address - http://172.17.0.1:80 + +x-logging: &default-logging + driver: json-file + options: + max-size: "5m" + max-file: "1" + services: gitea: image: casjaysdevdocker/gitea:latest + pull_policy: always container_name: casjaysdevdocker-gitea-latest hostname: git.example.com domainname: example.com privileged: true tty: true restart: always + logging: *default-logging + cgroupns_mode: private cap_add: - CHOWN - SYS_TIME - SYS_ADMIN environment: - - TZ=America/New_York - - HOSTNAME=git.example.com - - GITEA_PROTO=http - - DATABASE_DIR_SQLITE=/data/db/sqlite + TZ: ${TZ:-America/New_York} + CONTAINER_NAME: casjaysdevdocker-gitea-latest + HOSTNAME: ${BASE_HOST_NAME:-git.example.com} + GITEA_PROTO: http + DATABASE_DIR_SQLITE: /data/db/sqlite volumes: - - /srv/docker/gitea/data:/data:z - - /srv/docker/gitea/config:/config:z - - /srv/docker/databases/sqlite/gitea:/data/db/sqlite:z + - ./volumes/data:/data:z + - ./volumes/config:/config:z + - ./volumes/db/sqlite:/data/db/sqlite:z ports: - - 80:80 - - 22:22 + - "172.17.0.1:80:80" + - "172.17.0.1:22:22" + networks: + - gitea + +networks: + gitea: + name: gitea + external: false ``` ### Environment variables