casjaysdevdocker/gitea
1
0
Fork 0
mirror of https://github.com/casjaysdevdocker/gitea synced 2026-08-14 14:01:17 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

🐛 Fix UUOC and missing grep guard in start-runners 🐛

Browse Source 
Replaced `echo "$SERVER_ADDRESS" | grep -q '://'` with the native bash
`[[ "$SERVER_ADDRESS" != *"://"* ]]` test, eliminating a useless
subshell/pipe and the missing `--` before the grep pattern that came
with it. Found by the `script-lint` agent while auditing the
act_runner cache-server integration.

- rootfs/usr/local/bin/start-runners: line 24 UUOC fix
- TODO.AI.md: marked the start-runners lint finding fixed; logged a
  new, separate line-length violation on line 36 (`RUNNER_LABELS`
  default is 781 chars) discovered during the same lint pass but not
  yet actioned
This commit is contained in:
jason
2026-08-05 23:22:20 -04:00
parent fc3e148bb2
commit 3fc96e70e2
2 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO.AI.md
+13 -8
View File
@@ -1,15 +1,20 @@
# TODO.AI.md
## Lint cleanup — pre-existing script-lint violations (found incidentally while wiring act_runner cache-server)
## Lint cleanup done — UUOC fixed (start-runners)
Not fixed yet — out of scope for the cache-enablement change; flagged by `script-lint` agent.
Verified clean by `script-lint` agent after fix.
- `rootfs/usr/local/bin/start-runners`:
- line 24: UUOC — `echo "$SERVER_ADDRESS" | grep -q '://'` should be `[[ "$SERVER_ADDRESS" == *"://"* ]]`
- line 24: `grep -q '://'` missing `--` before query
- `rootfs/usr/local/etc/docker/init.d/zz-act_runner.sh`:
- line 4: `##@Version` header present but no matching `VERSION=` assignment in script body
- missing `--` before the grep query at lines 124 (x2), 130, 133, 134, 369, 390, 401, 438, 468, 525 (x2), 544 (x2, also should quote the `grep` pattern), 571, 583
- `rootfs/usr/local/bin/start-runners`: line 24 UUOC (`echo | grep -q '://'`) replaced with
`[[ "$SERVER_ADDRESS" != *"://"* ]]`; grep call removed entirely so the missing `--` no longer
applies.
## New lint finding — line-length violation (start-runners)
Found by `script-lint` while verifying the fixes above; unrelated to those fixes, not yet actioned.
- `rootfs/usr/local/bin/start-runners` line 36: `RUNNER_LABELS="${RUNNER_LABELS:-...}"` default
value is 781 characters, exceeds the 180-char line limit. Needs splitting across multiple lines
(e.g. build the default via an array or heredoc instead of one long string literal).
## App-breaking bug fixed — DEBUGGER guard pattern under set -e (functions/entrypoint.sh)
rootfs/usr/local/bin/start-runners
+1 -1
View File
@@ -21,7 +21,7 @@ trap __cleanup SIGTERM SIGINT
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
# Validate required environment variables
if [ -n "$SERVER_ADDRESS" ]; then
if ! echo "$SERVER_ADDRESS" | grep -q '://'; then
if [[ "$SERVER_ADDRESS" != *"://"* ]]; then
SERVER_ADDRESS="http://$SERVER_ADDRESS"
fi
else